Re: Pluggable Storage - Andres's take

On Mon, Sep 10, 2018 at 7:33 PM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> On Mon, Sep 10, 2018 at 1:12 PM Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com> wrote:
>>
>> On Wed, Sep 5, 2018 at 2:04 PM Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com> wrote:
>>>
>> pg_stat_get_tuples_hot_updated and others:
>> /*
>> * Counter tuples_hot_updated stores number of hot updates for heap table
>> * and the number of inplace updates for zheap table.
>> */
>> if ((tabentry = pgstat_fetch_stat_tabentry(relid)) == NULL ||
>> RelationStorageIsZHeap(rel))
>> result = 0;
>> else
>> result = (int64) (tabentry->tuples_hot_updated);
>>
>>
>> Is the special condition is needed? The values should be 0 because of zheap right?
>>
>
> I also think so. Beena/Mithun has worked on this part of the code, so
> it is better if they also confirm once.

Yes pg_stat_get_tuples_hot_updated should return 0 for zheap.

--
Thanks and Regards
Mithun C Y
EnterpriseDB: http://www.enterprisedb.com