Re: Patch: Implement failover on libpq connect level.

From: Mithun Cy <mithun(dot)cy(at)enterprisedb(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Kuntal Ghosh <kuntalghosh(dot)2007(at)gmail(dot)com>, Catalin Iacob <iacobcatalin(at)gmail(dot)com>, "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com>, Craig Ringer <craig(at)2ndquadrant(dot)com>, Peter van Hardenberg <pvh(at)pvh(dot)ca>, Peter Eisentraut <peter_e(at)gmx(dot)net>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Patch: Implement failover on libpq connect level.
Date: 2016-11-30 01:44:29
Message-ID: CAD__Ouj+wCZE0S3b8Jxj5rgP2iAq15KC9dK6uiZV7ufq9-JMGQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-jdbc

On Wed, Nov 30, 2016 at 1:44 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>On Tue, Nov 29, 2016 at 2:19 PM, Kuntal Ghosh <kuntalghosh(dot)2007(at)gmail(dot)com>
wrote:
>> I was doing some testing with the patch and I found some inconsistency
>> in the error message.

> Hmm, maybe the query buffer is getting cleared someplace in there. We
> might need to save/restore it.

Thanks, send query resets the errorMessage. Will fix same.

* PQsendQuery()->PQsendQueryStart()->resetPQExpBuffer(&conn->errorMessage);*

Thanks and Regards
Mithun C Y
EnterpriseDB: http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Chris Bandy 2016-11-30 02:57:16 Re: GiST support for UUIDs
Previous Message Craig Ringer 2016-11-30 01:40:57 Re: patch: function xmltable

Browse pgsql-jdbc by date

  From Date Subject
Next Message Jorge Solórzano 2016-11-30 04:00:24 Re: Versioning policy PgJDBC - discussion
Previous Message Dave Cramer 2016-11-30 01:31:51 Re: Versioning policy PgJDBC - discussion