| From: | Mithun Cy <mithun(dot)cy(at)enterprisedb(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Jesper Pedersen <jesper(dot)pedersen(at)redhat(dot)com>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: Cache Hash Index meta page. |
| Date: | 2017-01-13 04:28:16 |
| Message-ID: | CAD__OuguwKqKeGFXLqs6D3fshTR83Zo6FrKd79DGVR17gJY+Tg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jan 6, 2017 at 11:43 AM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> Few more comments:
> 1.
> no need to two extra lines, one is sufficient and matches the nearby
> coding pattern.
-- Fixed.
> 2.
> Do you see anywhere else in the code the pattern of using @ symbol in
> comments before function name?
-- Fixed.
> 3.
>
> after this change, i think you can directly use bucket in
> _hash_finish_split instead of pageopaque->hasho_bucket
-- Fixed.
> 4.
>
> Won't the check similar to the existing check (if (*bufp ==
> so->hashso_bucket_buf || *bufp == so->hashso_split_bucket_buf)) just
> above this code will suffice the need? If so, then you can check it
> once and use it in both places.
>
-- Fixed.
> 5. The reader and insertion algorithm needs to be updated in README.
-- Added info in README.
--
Thanks and Regards
Mithun C Y
EnterpriseDB: http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| cache_hash_index_meta_page_11.patch | application/octet-stream | 20.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Mithun Cy | 2017-01-13 04:41:54 | Re: Cache Hash Index meta page. |
| Previous Message | Michael Paquier | 2017-01-13 04:26:49 | Re: Patch to implement pg_current_logfile() function |