| From: | João Rito <joaovictor(dot)rito(at)gmail(dot)com> |
|---|---|
| To: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
| Cc: | Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] Explain what the default output_plugin_libraries do |
| Date: | 2026-11-11 22:13:23 |
| Message-ID: | CADMs5ONvXvbuwyJwHEbG4U=qRZupLJw3gkyXbYrS85+q6=KCuw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Kuroda-san,
Thanks for checking this and for testing it.
You are right, and I withdraw my wording comment. Before, I had only
read the patch. This time I applied the v2 doc patch to current master
(8d87367b39e) and tested each sentence of the new section against the
server:
- I moved test_decoding.so out of $libdir. Creating a test_decoding
slot then fails with 'could not access file "test_decoding": No such
file or directory'. After adding the new directory to
dynamic_library_path and reloading, the slot is created by name. So
the "dynamically loadable library" and dynamic_library_path sentences
match the behavior, as your pgoutput test also showed.
- The slot is created without LOAD and without CREATE EXTENSION
(test_decoding is not in pg_extension).
- With output_plugin_libraries = 'pgoutput', creating a test_decoding
slot fails with 'library "test_decoding" may not be used as an output
plugin', with the HINT to add it to output_plugin_libraries. pgoutput
still works, and after RESET the test_decoding slot works again.
- The xmllint validation (make check in doc/src/sgml) reported no
errors, make html finished, and all the links in the new section
resolve.
So the section looks good to me. Sorry for the noise earlier.
Thanks,
João
| From | Date | Subject | |
|---|---|---|---|
| Next Message | João Rito | 2026-11-11 22:15:08 | Re: Why is the LSN reported for pg_logical_emit_message() different from other decoded operations? |
| Previous Message | João Rito | 2026-11-11 22:12:30 | Re: Fix for consume_xids advancing XIDs incorrectly |