Re: More protocol.h replacements this time into walsender.c

From: Dave Cramer <davecramer(at)gmail(dot)com>
To: Nathan Bossart <nathandbossart(at)gmail(dot)com>
Cc: Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: More protocol.h replacements this time into walsender.c
Date: 2025-07-28 19:15:23
Message-ID: CADK3HHLs-8fTiYikJBU45bkMYABVifkYPQU9s3vwO4EUcuOo=w@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, 25 Jul 2025 at 10:38, Nathan Bossart <nathandbossart(at)gmail(dot)com>
wrote:

> On Thu, Jul 24, 2025 at 05:39:14PM -0400, Dave Cramer wrote:
> > On Thu, 24 Jul 2025 at 17:05, Jacob Champion <
> > jacob(dot)champion(at)enterprisedb(dot)com> wrote:
> >> Since these are part of the replication subprotocol (i.e. tunneled,
> >> via CopyData) rather than the top-level wire protocol, do they deserve
> >> their own prefix? PqReplMsg_* maybe?
> >>
> > I'm going to wait to see if there are any other opinions. Last time I did
> > this there were quite a few opinions before finally settling on the
> naming
>
> +1 to a new prefix. I don't have any strong opinions on the exact choice,
> though. PqReplMsg, ReplMsg, PqMsg_Repl, etc. seem like some obvious
> options.
>
> I chose PqReplMsg patch attached

Dave

Attachment Content-Type Size
0001-Rename-replication-messages-to-start-with-PqReplMsg.patch application/octet-stream 6.5 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2025-07-28 19:33:28 Re: Make COPY format extendable: Extract COPY TO format implementations
Previous Message Bruce Momjian 2025-07-28 18:54:52 Re: PG 18 beta1 release notes misses mention of pg_noreturn