Re: let's make the list of reportable GUCs configurable (was Re: Add %r substitution for psql prompts to show recovery status)

From: Dave Cramer <pg(at)fastcrypt(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Craig Ringer <craig(at)2ndquadrant(dot)com>, "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp>, Ian Barwick <ian(dot)barwick(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: let's make the list of reportable GUCs configurable (was Re: Add %r substitution for psql prompts to show recovery status)
Date: 2019-07-11 16:08:54
Message-ID: CADK3HHJVh+JkVzdpu301OytD1-5haR=CSaQrPHdSRsuERXn2jA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, 11 Jul 2019 at 10:19, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:

> On Thu, Jul 11, 2019 at 10:11 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> > > 3. I'm not sure that just ignoring any GUCs we don't find is the right
> > > thing. I'm also not sure that it's the wrong thing, but it might be.
> > > My question is: what if there's an extension-owned GUC in play? The
> > > library probably isn't even loaded at this stage, unless it's in
> > > shared_preload_libraries.
> >
> > Gut reaction is that define_custom_variable would need to consult
> > the list to see if a newly-defined variable should be marked GUC_REPORT.
>

This suggests creating a list in guc.c instead. I'm unclear as to the
visibility of variables in there
How do I make this list visible only to the session ?

Dave Cramer

davec(at)postgresintl(dot)com
www.postgresintl.com

>
>

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alexander Korotkov 2019-07-11 16:13:49 Re: Add missing operator <->(box, point)
Previous Message Andrew Dunstan 2019-07-11 16:04:04 Re: pgbench - add option to show actual builtin script code