Re: Binary support for pgoutput plugin

From: Dave Cramer <davecramer(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Binary support for pgoutput plugin
Date: 2020-02-29 15:44:44
Message-ID: CADK3HHJ-jJ8ROhXBHyGxnZdnvExeKZaNa95xLY2pP8PPBcAniw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, 28 Feb 2020 at 18:34, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:

> Dave Cramer <davecramer(at)gmail(dot)com> writes:
> > Rebased against head
>
> The cfbot's failing to apply this [1]. It looks like the reason is only
> that you included a catversion bump in what you submitted. Protocol is to
> *not* do that in submitted patches, but rely on the committer to add it at
> the last minute --- otherwise you'll waste a lot of time rebasing the
> patch, which is what it needs now.
>
> regards, tom lane
>
> [1] http://cfbot.cputube.org/patch_27_2152.log

rebased and removed the catversion bump.

Attachment Content-Type Size
0006-make-sure-the-subcription-is-marked-as-binary.patch application/octet-stream 829 bytes
0003-document-new-binary-option-for-CREATE-SUBSCRIPTION.patch application/octet-stream 2.9 KB
0002-add-binary-column-to-pg_subscription.patch application/octet-stream 8.6 KB
0004-get-relid-inside-of-logical_read_insert.patch application/octet-stream 2.5 KB
0005-Remove-C99-declaration-and-code.patch application/octet-stream 1.3 KB
0001-First-pass-at-working-code-without-subscription-opti.patch application/octet-stream 21.3 KB
0007-check-that-the-subscriber-is-compatible-with-the-pub.patch application/octet-stream 7.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Krasiyan Andreev 2020-02-29 15:54:51 [PATCH] respect/ignore nulls for lag,lead,first_value,last_value and nth_value and from first/last for nth_value
Previous Message Justin Pryzby 2020-02-29 14:53:04 Re: Allow CLUSTER, VACUUM FULL and REINDEX to change tablespace on the fly