Re: Buildfarm now building but with test failures

Tom,

At what version will the server accept non quoted language identifier ?

We need the tests to pass on at least 8.4 I would think.

Dave Cramer

dave.cramer(at)credativ(dot)ca
http://www.credativ.ca

On Wed, Jan 4, 2012 at 11:26 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> "Mike Fowler" <mike(at)mlfowler(dot)com> writes:
>> HEAD is failing in a completely different way. A sample from the logs:
>> [junit] ERROR: language "SQL" does not exist
>
> I believe that's something Robert changed recently.  We used to forcibly
> downcase language names even if quoted, but he successfully argued that
> that was inconsistent and unnecessary.  So I'm guessing your test suite
> contains CREATE FUNCTION ... LANGUAGE "SQL", and you should remove the
> quotes.
>
> [ digs in logs... ]  Ah, here we are:
>
> Author: Robert Haas <rhaas(at)postgresql(dot)org>
> Branch: master [67dc4eed4] 2011-11-17 14:25:18 -0500
>
>    Remove ancient downcasing code from procedural language operations.
>
>    A very long time ago, language names were specified as literals rather
>    than identifiers, so this code was added to do case-folding.  But that
>    style has ben deprecated for many years so this isn't needed any more.
>    Language names will still be downcased when specified as unquoted
>    identifiers, but quoted identifiers or the old style using string
>    literals will be left as-is.
>
>                        regards, tom lane