From: | Dave Cramer <davecramer(at)postgres(dot)rocks> |
---|---|
To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
Cc: | Andres Freund <andres(at)anarazel(dot)de>, Michael Paquier <michael(at)paquier(dot)xyz>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Vladimir Sitnikov <sitnikov(dot)vladimir(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: SIGSEGV from START_REPLICATION 0/XXXXXXX in XLogSendPhysical () at walsender.c:2762 |
Date: | 2020-06-05 13:04:31 |
Message-ID: | CADK3HH+BawQ+DHd6ZMfQcC_+__=eOnaW_A=JVxupe7jeN5Qg5g@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, 4 Jun 2020 at 19:46, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
wrote:
> On 2020-Jun-04, Andres Freund wrote:
>
> > postgres[52656][1]=# SELECT 1;
> > ┌──────────┐
> > │ ?column? │
> > ├──────────┤
> > │ 1 │
> > └──────────┘
> > (1 row)
> >
> >
> > I am very much not in love with the way that was implemented, but it's
> > there, and it's used as far as I know (cf tablesync.c).
>
> Ouch ... so they made IDENT in the replication grammar be a trigger to
> enter the regular grammar. Crazy. No way to put those worms back in
> the tin now, I guess.
>
Is that documented ?
>
> It is still my opinion that we should prohibit a logical replication
> connection from being used to do physical replication. Horiguchi-san,
> Sawada-san and Masao-san are all of the same opinion. Dave Cramer (of
> the JDBC team) is not opposed to the change -- he says they're just
> using it because they didn't realize they should be doing differently.
I think my exact words were
"I don't see this is a valid reason to keep doing something. If it is
broken then fix it.
Clients can deal with the change."
in response to:
Well, I don't really think that we can just break a behavior that
> exists since 9.4 as you could break applications relying on the
> existing behavior, and that's also the point of Vladimir upthread.
>
Which is different than not being opposed to the change. I don't see this
as broken,
and it's quite possible that some of our users are using it. It certainly
needs to be documented
Dave
From | Date | Subject | |
---|---|---|---|
Next Message | Inoue, Hiroshi | 2020-06-05 13:25:00 | Re: Removal of currtid()/currtid2() and some table AM cleanup |
Previous Message | 이동욱 | 2020-06-05 12:45:52 | Re: [PATCH] pg_dump: Add example and link for --encoding option |