Re: Error on failed COMMIT

From: Dave Cramer <davecramer(at)postgres(dot)rocks>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Vik Fearing <vik(at)postgresfriends(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>, Vladimir Sitnikov <sitnikov(dot)vladimir(at)gmail(dot)com>, Shay Rojansky <roji(at)roji(dot)org>, "Haumacher, Bernhard" <haui(at)haumacher(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Error on failed COMMIT
Date: 2020-03-30 16:05:03
Message-ID: CADK3HH+20CJ6TqWcbYnbi2_99CJNtzr_9ctV-dEsRePQaKGaeA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, 17 Mar 2020 at 19:32, Dave Cramer <davecramer(at)postgres(dot)rocks> wrote:

>
>
> On Tue, 17 Mar 2020 at 19:23, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
>
>> On Tue, Mar 17, 2020 at 07:15:05PM -0400, Dave Cramer wrote:
>> > On Tue, 17 Mar 2020 at 16:47, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
>> > Third, the idea that individual interfaces, e.g. JDBC, should throw
>> an
>> > error in this case while the server just changes the COMMIT return
>> tag
>> > to ROLLBACK is confusing. People regularly test SQL commands in the
>> > server before writing applications or while debugging, and a
>> behavior
>> > mismatch would cause confusion.
>> >
>> >
>> > I'm not sure what you mean by this. The server would throw an error.
>>
>> I am saying it is not wise to have interfaces behaving differently than
>> the server, for the reasons stated above.
>>
>> Agreed and this is why I think it is important for the server to be
> defining the behaviour instead of each interface deciding how to handle
> this situation.
>
>
>
So it appears this is currently languishing as unresolved and feature
freeze is imminent.

What has to be done to get a decision one way or another before feature
freeze.

I have provided a patch that could be reviewed and at least be considered
in the commitfest.

Perhaps someone can review the patch and I can do whatever it takes to get
it presentable ?

Dave Cramer
www.postgres.rocks

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2020-03-30 16:06:44 materialization blocks hash join
Previous Message David Steele 2020-03-30 15:51:33 Re: [PATCH] Atomic pgrename on Windows