Re: Partitioning vs ON CONFLICT

From: Rukh Meski <rukh(dot)meski(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Peter Geoghegan <pg(at)bowt(dot)ie>, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, "Shinoda, Noriyoshi" <noriyoshi(dot)shinoda(at)hpe(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Thom Brown <thom(at)linux(dot)com>
Subject: Re: Partitioning vs ON CONFLICT
Date: 2017-04-01 12:35:22
Message-ID: CADB9FDdhwRMmg9xgtScQpQN1twF+9z5+Zk3fevkw3OnR1vOuYQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Mar 31, 2017 at 11:44 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Fri, Mar 31, 2017 at 5:33 PM, Peter Geoghegan <pg(at)bowt(dot)ie> wrote:
>> In my opinion, for the very limited ON CONFLICT DO NOTHING + no
>> inference specification case, the implementation should not care about
>> the presence or absence of unique indexes within or across partitions.
>
> Hmm. That's an interesting point. The documentation says:
>
> ON CONFLICT can be used to specify an alternative action to raising a
> unique constraint or exclusion constraint violation error.
>
> And, indeed, you could get an unique constraint or exclusion error
> because of an index on the child even though it's not global to the
> partitioning hierarchy. So maybe we can support this after all, but
> having messed it up once, I'm inclined to think we should postpone
> this to v11, think it over some more, and try to make sure that our
> second try doesn't crash...

Naturally this means that the partitioning work will be reverted as
well, since we have a consensus that new features shouldn't make
preexisting ones worse. It's a shame, since I was really hoping to see
it in 10.0.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2017-04-01 12:41:28 Re: [sqlsmith] Failed assertion in _hash_kill_items/MarkBufferDirtyHint
Previous Message Amit Kapila 2017-04-01 12:23:51 Re: Page Scan Mode in Hash Index