Re: My first patch! (to \df output)

From: Phil Sorber <phil(at)omniti(dot)com>
To: Jon Erdman <postgresql(at)thewickedtribe(dot)net>
Cc: Craig Ringer <craig(at)2ndquadrant(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, PostgreSQL-development Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: My first patch! (to \df output)
Date: 2013-01-23 05:17:39
Message-ID: CADAkt-j8Wi_t+fQ0zNJ+QcvNh4NhoS_N_OuV86w5vNOoa50oVA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jan 23, 2013 at 12:10 AM, Jon Erdman
<postgresql(at)thewickedtribe(dot)net> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
>
> Updated the patch in commitfest with the doc change, and added a
> comment to explain the whitespace change (it was to clean up the sql
> indentation). I've also attached the new patch here for reference.

Docs looks good. Spaces gone.

Still need to replace 'definer' and 'invoker' with %s and add the
corresponding gettext_noop() calls I think.

> - --
> Jon T Erdman (aka StuckMojo)
> PostgreSQL Zealot
>
> On 01/20/2013 08:27 PM, Craig Ringer wrote:
>> On 01/19/2013 11:54 PM, Jon Erdman wrote:
>>> I did realize that since I moved it to + the doc should change,
>>> but I didn't address that. I'll get on it this weekend.
>> Held as waiting on author, then. Please update
>> https://commitfest.postgresql.org/action/patch_view?id=1008 when
>> you post a new revision.
>>
>> -- Craig Ringer http://www.2ndQuadrant.com/
>> PostgreSQL Development, 24x7 Support, Training & Services
>>
> -----BEGIN PGP SIGNATURE-----
> Comment: Using GnuPG with undefined - http://www.enigmail.net/
>
> iEYEARECAAYFAlD/cNYACgkQRAk1+p0GhSGwJQCfa+8SbL9cYHZkqfmlRlgqcXf9
> qD4AnjSZwSXQmOMK8thSs6CdiDxQkJCJ
> =H+km
> -----END PGP SIGNATURE-----

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jeff Janes 2013-01-23 05:29:03 Re: BUG #7814: Rotation of the log is not carried out.
Previous Message Jon Erdman 2013-01-23 05:10:46 Re: My first patch! (to \df output)