Re: palloc unification

From: Phil Sorber <phil(at)omniti(dot)com>
To: Simon Riggs <simon(at)2ndquadrant(dot)com>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: palloc unification
Date: 2013-02-06 15:01:50
Message-ID: CADAkt-gmw6X5a1DeNz9ZUrxcRa8Re=-ApEeOLsf=RL4fUUWGdg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Feb 6, 2013 at 9:59 AM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
> On 6 February 2013 14:38, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:
>> Robert Haas escribió:
>>> On Mon, Feb 4, 2013 at 5:50 PM, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:
>>
>>> > I propose to have a new subdirectory src/include/shared, and two
>>> > header files:
>>
>>> > The frontend (pg_malloc) function definitions would live somewhere in,
>>> > say, src/shared/fe_memutils.c. For the palloc() implementation, I think
>>> > we should create another file, so that frontend-only programs that do
>>> > not require those symbols (most of them) are not unnecessarily bloated.
>>> >
>>> > Opinions on having a new subdir?
>>
>>> I like the idea of having a place for shared frontend and backend code
>>> very much, but I don't think src/include/shared or src/shared is a
>>> good name, because "shared" can mean a lot of things - like "shared
>>> library", for example. I think that this should be set up in a manner
>>> analogous to libpgport, except not for portability code, but instead
>>> for other stuff. Maybe we could call it libpgframework or something.
>>
>> Yeah, I am doing this right now and the "shared" name doesn't seem so
>> good. "libpgframework" sounds decent. So since libpgport comes from
>> src/port, are we okay with src/framework and src/include/framework?
>
> "common" ?
>
> src/backend/common
> src/include/common

+1

>
> --
> Simon Riggs http://www.2ndQuadrant.com/
> PostgreSQL Development, 24x7 Support, Training & Services
>
>
> --
> Sent via pgsql-hackers mailing list (pgsql-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-hackers

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Phil Sorber 2013-02-06 15:05:05 Re: [PATCH] pg_isready (was: [WIP] pg_ping utility)
Previous Message Simon Riggs 2013-02-06 14:59:47 Re: palloc unification