| From: | Kevin Hale Boyes <kcboyes(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Oleksii Kliukin <alexk(at)hintbits(dot)com>, Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, Alexander Kukushkin <cyberdemn(at)gmail(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Magnus Hagander <magnus(at)hagander(dot)net>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Connection slots reserved for replication |
| Date: | 2019-02-12 03:57:41 |
| Message-ID: | CADAecHVAD4=26KAx4nj5DBvxqqvJkuwsy+riiiNhQqwnZg2K8Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, 11 Feb 2019 at 18:39, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> And done.
Michael,
I think there's a small problem with the commit.
The position of xlrec.max_wal_senders (line 117) should be below
max_worker_processes.
112
<https://git.postgresql.org/gitweb/?p=postgresql.git;a=blob;f=src/backend/access/rmgrdesc/xlogdesc.c;h=0ad4454a8c6c2e98175d59e13965b15e22b8f762;hb=ea92368cd1da1e290f9ab8efb7f60cb7598fc310#l112>
appendStringInfo(buf, "max_connections=%d max_worker_processes=%d "
113
<https://git.postgresql.org/gitweb/?p=postgresql.git;a=blob;f=src/backend/access/rmgrdesc/xlogdesc.c;h=0ad4454a8c6c2e98175d59e13965b15e22b8f762;hb=ea92368cd1da1e290f9ab8efb7f60cb7598fc310#l113>
"max_wal_senders=%d max_prepared_xacts=%d "
114
<https://git.postgresql.org/gitweb/?p=postgresql.git;a=blob;f=src/backend/access/rmgrdesc/xlogdesc.c;h=0ad4454a8c6c2e98175d59e13965b15e22b8f762;hb=ea92368cd1da1e290f9ab8efb7f60cb7598fc310#l114>
"max_locks_per_xact=%d wal_level=%s "
115
<https://git.postgresql.org/gitweb/?p=postgresql.git;a=blob;f=src/backend/access/rmgrdesc/xlogdesc.c;h=0ad4454a8c6c2e98175d59e13965b15e22b8f762;hb=ea92368cd1da1e290f9ab8efb7f60cb7598fc310#l115>
"wal_log_hints=%s track_commit_timestamp=%s",
116
<https://git.postgresql.org/gitweb/?p=postgresql.git;a=blob;f=src/backend/access/rmgrdesc/xlogdesc.c;h=0ad4454a8c6c2e98175d59e13965b15e22b8f762;hb=ea92368cd1da1e290f9ab8efb7f60cb7598fc310#l116>
xlrec.MaxConnections,
117
<https://git.postgresql.org/gitweb/?p=postgresql.git;a=blob;f=src/backend/access/rmgrdesc/xlogdesc.c;h=0ad4454a8c6c2e98175d59e13965b15e22b8f762;hb=ea92368cd1da1e290f9ab8efb7f60cb7598fc310#l117>
xlrec.max_wal_senders,
118
<https://git.postgresql.org/gitweb/?p=postgresql.git;a=blob;f=src/backend/access/rmgrdesc/xlogdesc.c;h=0ad4454a8c6c2e98175d59e13965b15e22b8f762;hb=ea92368cd1da1e290f9ab8efb7f60cb7598fc310#l118>
xlrec.max_worker_processes,
119
<https://git.postgresql.org/gitweb/?p=postgresql.git;a=blob;f=src/backend/access/rmgrdesc/xlogdesc.c;h=0ad4454a8c6c2e98175d59e13965b15e22b8f762;hb=ea92368cd1da1e290f9ab8efb7f60cb7598fc310#l119>
xlrec.max_prepared_xacts,
120
<https://git.postgresql.org/gitweb/?p=postgresql.git;a=blob;f=src/backend/access/rmgrdesc/xlogdesc.c;h=0ad4454a8c6c2e98175d59e13965b15e22b8f762;hb=ea92368cd1da1e290f9ab8efb7f60cb7598fc310#l120>
xlrec.max_locks_per_xact,
121
<https://git.postgresql.org/gitweb/?p=postgresql.git;a=blob;f=src/backend/access/rmgrdesc/xlogdesc.c;h=0ad4454a8c6c2e98175d59e13965b15e22b8f762;hb=ea92368cd1da1e290f9ab8efb7f60cb7598fc310#l121>
wal_level_str,
122
<https://git.postgresql.org/gitweb/?p=postgresql.git;a=blob;f=src/backend/access/rmgrdesc/xlogdesc.c;h=0ad4454a8c6c2e98175d59e13965b15e22b8f762;hb=ea92368cd1da1e290f9ab8efb7f60cb7598fc310#l122>
xlrec.wal_log_hints ? "on" : "off",
123
<https://git.postgresql.org/gitweb/?p=postgresql.git;a=blob;f=src/backend/access/rmgrdesc/xlogdesc.c;h=0ad4454a8c6c2e98175d59e13965b15e22b8f762;hb=ea92368cd1da1e290f9ab8efb7f60cb7598fc310#l123>
xlrec.track_commit_timestamp ? "on" : "off");
Kevin.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2019-02-12 04:09:42 | Re: pg11.1: dsa_area could not attach to segment |
| Previous Message | Alvaro Herrera | 2019-02-12 03:18:25 | Re: monitoring CREATE INDEX [CONCURRENTLY] |