Re: pgsql: Fix perltidy breaking perlcritic

On Fri, Sep 9, 2022 at 10:44 PM John Naylor <john(dot)naylor(at)enterprisedb(dot)com>
wrote:

> On Fri, Sep 9, 2022 at 3:32 AM Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>
> > A better way do do this IMNSHO is to put the eval in a block on its own
> along with the no critic marker on its own line, like this:
> >
> > {
> > ## no critic (ProhibitStringyEval)
> > eval ...
> > }
> >
> > perlcritic respects block boundaries for its directives.
>
> I tried that in the attached -- it looks a bit nicer but requires more
> explanation. I don't have strong feelings either way.
>
>
Maybe even better would be just this, which I bet perltidy would not monkey
with, and would require no explanation:

eval "\$hash_ref = $_"; ## no critic (ProhibitStringyEval)

cheers

andrew