| From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | Kyle Conroy <kyle(at)kyleconroy(dot)com>, pgsql-bugs <pgsql-bugs(at)postgresql(dot)org> |
| Subject: | Re: BUG #14775: Incorrect documentation for the Commit logical replication message format |
| Date: | 2017-08-15 01:30:46 |
| Message-ID: | CAD21AoDynu2TmPY-1FerBjb5nmQr1cswtfqZce_7QYYX6yJPBA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Tue, Aug 15, 2017 at 2:45 AM, Peter Eisentraut
<peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
> On 8/10/17 04:21, Masahiko Sawada wrote:
>>> The Commit message format is incorrectly documented. The `flags` field[0] is
>>> missing. I ran into this while creating a parser for the messages in
>>> Golang.
>>>
>>> [0]
>>> https://github.com/postgres/postgres/blob/master/src/backend/replication/logical/proto.c#L80
>>>
>>
>> Thank you for reporting. Yeah, it's not used actually for now but
>> should be documented. Attached patch.
>
> Committed, thanks!
>
Thank you for committing!
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Noah Misch | 2017-08-15 02:52:43 | Re: [postgresql 10 beta3] unrecognized node type: 90 |
| Previous Message | Tom Lane | 2017-08-14 23:11:58 | Re: Crash report for some ICU-52 (debian8) COLLATE and work_mem values |