From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
---|---|
To: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Declared but no defined functions |
Date: | 2019-07-05 05:51:32 |
Message-ID: | CAD21AoDuAYsRb3Q9aobkFZ6DZMWxsyg4HOmgkwgeWNfSkTwGxw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi,
I realized that TransactionIdAbort is declared in the transam.h but
there is not its function body. As far as I found there are three
similar functions in total by the following script.
for func in `git ls-files | egrep "\w+\.h$" | xargs cat | egrep
"extern \w+ \w+\(.*\);" | sed -e "s/.* \(.*\)(.*);/\1(/g"`
do
if [ `git grep "$func" -- "*.c" | wc -l` -lt 1 ];then
echo $func
fi
done
I think the following functions are mistakenly left in the header
file. So attached patch removes them.
dsa_startup()
TransactionIdAbort()
renameatt_type()
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
Attachment | Content-Type | Size |
---|---|---|
remove_func_declaration.patch | application/x-patch | 1.7 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Pavel Stehule | 2019-07-05 05:58:21 | Re: range_agg |
Previous Message | Thomas Munro | 2019-07-05 05:36:53 | Re: Add client connection check during the execution of the query |