Re: BUG #19368: f54af9f does not create the correct macro for autotools build

From: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: evsi(at)amazon(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org, Andres Freund <andres(at)anarazel(dot)de>
Subject: Re: BUG #19368: f54af9f does not create the correct macro for autotools build
Date: 2025-12-31 19:20:17
Message-ID: CAD21AoDtWPEbuGB5dq0d1JK=+tCDj8OqLobEpyajSrZ6NrCZCg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Wed, Dec 31, 2025 at 8:52 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> writes:
> > On Wed, Dec 31, 2025 at 7:59 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> >> This is indeed busted, but I'd argue that the autoconf build has the
> >> right macro name and meson and the C code are using the wrong one:
>
> > Agreed. The attached patch should fix the issue.
>
> You beat me to it ;-). Patch LGTM.

Thank you for reviewing the patch! Pushed.

Regards,

--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Paul A Jungwirth 2025-12-31 22:47:42 Re: BUG #19098: Can't create unique gist index, where pg_indexes says that WITHOUT OVERLAPS does exacly that
Previous Message Tom Lane 2025-12-31 16:52:21 Re: BUG #19368: f54af9f does not create the correct macro for autotools build