Re: Skipping logical replication transactions on subscriber side

On Fri, Oct 8, 2021 at 9:22 PM osumi(dot)takamichi(at)fujitsu(dot)com
<osumi(dot)takamichi(at)fujitsu(dot)com> wrote:
>
> On Thursday, September 30, 2021 2:45 PM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> > I've attached updated patches that incorporate all comments I got so far. Please
> > review them.
> Hello
>
>
> Minor two comments for v15-0001 patch.
>
> (1) a typo in pgstat_vacuum_subworker_stat()
>
> + /*
> + * This subscription is live. The next step is that we search errors
> + * of the table sync workers who are already in sync state. These
> + * errors should be removed.
> + */
>
> This subscription is "alive" ?
>
>
> (2) Suggestion to add one comment next to '0' in ApplyWorkerMain()
>
> + /* report the table sync error */
> + pgstat_report_subworker_error(MyLogicalRepWorker->subid,
> + MyLogicalRepWorker->relid,
> + MyLogicalRepWorker->relid,
> + 0,
> + InvalidTransactionId,
> + errdata->message);
>
> How about writing /* no corresponding message type for table synchronization */ or something ?
>

Thank you for the comments! Those comments are incorporated into the
latest patches I just submitted[1].

Regards,

[1] https://www.postgresql.org/message-id/CAD21AoDST8-ykrCLcWbWnTLj1u52-ZhiEP%2BbRU7kv5oBhfSy_Q%40mail.gmail.com

--
Masahiko Sawada
EDB: https://www.enterprisedb.com/