| From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: RemoveSubscriptionRel uses simple_heap_delete |
| Date: | 2017-06-14 17:41:59 |
| Message-ID: | CAD21AoDjUvS6E_YACXo7qbLbfpU-DpJ9wPv=q5Yww5d4EyGJmA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jun 14, 2017 at 10:44 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> writes:
>> Currently $subject but should we use CatalogTupleDelete() instead?
>> It's actually the same behavior though. Other functions use
>> CatalogTupleXXX(). Attached patch.
>
> Yeah, evidently that patch failed to track the effects of commits
> 2f5c9d9c9 et al, since it wasn't in-tree yet. Poking around, at
> least statscmds.c has got the same disease.
>
Thank you for fixing it!
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2017-06-14 17:49:49 | Re: v10beta pg_catalog diagrams |
| Previous Message | Tom Lane | 2017-06-14 17:31:21 | Re: pgindent (was Re: [COMMITTERS] pgsql: Preventive maintenance in advance of pgindent run.) |