Re: [HACKERS] Assertion failure when the non-exclusive pg_stop_backup aborted.

From: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] Assertion failure when the non-exclusive pg_stop_backup aborted.
Date: 2017-11-21 09:32:18
Message-ID: CAD21AoDdZ=E9fjHq2yijrEBu=G3F0dCWGFwtfPPTva20zWLR=Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On Tue, Nov 21, 2017 at 10:01 AM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> On Tue, Nov 21, 2017 at 9:37 AM, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>> On Tue, Nov 21, 2017 at 8:03 AM, Michael Paquier
>> <michael(dot)paquier(at)gmail(dot)com> wrote:
>>> You could just add "as this allows to keep backup counters kept in
>>> shared memory consistent with the state of the session starting or
>>> stopping a backup.".
>>
>> Thank you for the suggestion, Michael-san. Attached updated patch.
>> Please review it.
>
> [nit]
> + * or stoppping a backup.
> s/stoppping/stopping/

Oops.

> Fujii-san, please note that the same concept does not apply to
> do_pg_start_backup().
>
> * reason, *all* functionality between do_pg_start_backup() and
> - * do_pg_stop_backup() should be inside the error cleanup block!
> + * do_pg_stop_backup(), including do_pg_stop_backup() should be inside
> + * the error cleanup block!
> */
> Weirdly worded here. "between do_pg_start_backup until
> do_pg_stop_backup is done" sounds better?

Agreed.

Thank you for comments. Attached updated patch.

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

Attachment Content-Type Size
fix_do_pg_abort_backup_v9.patch application/octet-stream 3.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Moser 2017-11-21 09:36:30 Re: [HACKERS] [PROPOSAL] Temporal query processing with range types
Previous Message Daniel Gustafsson 2017-11-21 09:28:34 Re: Anybody care about having the verbose form of the tzdata files?