Use LW_SHARED in WakeupWalSummarizer() for WALSummarizerLock lock

From: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
To: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Use LW_SHARED in WakeupWalSummarizer() for WALSummarizerLock lock
Date: 2025-08-25 22:38:13
Message-ID: CAD21AoDdKhf_9oriEYxY-JCdF+Oe_muhca3pcdkMEdBMzyHyKw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi all,

While reading walsummarizer.c code, I noticed that in
WakeupWalSummarizer() we acquire the WALSummarizerLock lock in
LW_EXCLUSIVE mode despite only reading
WalSummarizerCtl->summarizer_pgprocno. The attached patch uses
LW_SHARED mode instead. Feedback is very welcome.

Regards,

--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com

Attachment Content-Type Size
v1-0001-Use-LW_SHARED-in-WakeupWalSummarizer-for-WALSumma.patch application/octet-stream 919 bytes

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jacob Champion 2025-08-25 22:38:59 Re: Support getrandom() for pg_strong_random() source
Previous Message Masahiko Sawada 2025-08-25 22:21:37 Re: Support getrandom() for pg_strong_random() source