| From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, jian he <jian(dot)universality(at)gmail(dot)com> |
| Subject: | Re: Fix bug of COPY TO support partition table |
| Date: | 2026-05-14 16:36:21 |
| Message-ID: | CAD21AoDbibkfCUZ+_kgcwKpvLsLv5g4AWT4=pOq5HpfAgQ6FEg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, May 14, 2026 at 9:25 AM Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>
> On Thu, May 14, 2026 at 7:00 PM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
> > As shown above, COPY incorrectly outputs all NULLs.
>
> Good catch!
Yeah, it should be fixed. Thank you for the report!
>
> > The fix is straightforward, just reverse the order of `rel` and `root_rel` when calling `build_attrmap_by_name_if_req()`. After the fix, COPY works correctly:
>
> Thanks for the patch! It looks good to me.
>
LGTM too. I'll take care of it as this is my commit, if you're okay
with it, Fujii-san.
Regards,
--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jim Jones | 2026-05-14 16:48:47 | Re: Fix bug with accessing to temporary tables of other sessions |
| Previous Message | Fujii Masao | 2026-05-14 16:25:11 | Re: Fix bug of COPY TO support partition table |