Re: Proposal : REINDEX xxx VERBOSE

From: Sawada Masahiko <sawada(dot)mshk(at)gmail(dot)com>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Proposal : REINDEX xxx VERBOSE
Date: 2015-02-02 13:56:55
Message-ID: CAD21AoDb2p8_Lj_Co91D-4aco7b5AH6NTU49=7JS7KYj1WYXNw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Feb 2, 2015 at 9:21 PM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> On Mon, Feb 2, 2015 at 8:31 PM, Sawada Masahiko <sawada(dot)mshk(at)gmail(dot)com> wrote:
>> Attached patch adds VERBOSE option to REINDEX commands.
>> Please give me feedbacks.
> This could provide useful feedback to users.

Thanks.

> Now, I think that it may
> be better to provide the keyword VERBOSE before the type of object
> reindexed as REINDEX [ VERBOSE ] object.

Actually, my first WIP version of patch added VERBOSE word at before
type of object.
I'm feeling difficult about that the position of VERBOSE word in
REINDEX statement.

> In any case, at quick sight,
> the table completion for REINDEX is broken with your patch because by
> typing REINDEX VERBOSE you would show the list of objects and once
> again VERBOSE.

I have also rebased the tab-completion source, I think it's not happen.
In my environment, it does not show list of object and VERBOSE again
after typing REINDEX VERBOSE.

Regards,

-------
Sawada Masahiko

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2015-02-02 13:58:03 Re: pg_basebackup fails with long tablespace paths
Previous Message Michael Paquier 2015-02-02 13:55:42 Re: Release note bloat is getting out of hand