Re: effective_wal_level is not decreasing after using REPACK (CONCURRENTLY)

From: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
To: Álvaro Herrera <alvherre(at)kurilemu(dot)de>
Cc: shveta malik <shveta(dot)malik(at)gmail(dot)com>, Imran Zaheer <imran(dot)zhir(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, shveta malik <shvetamalik(at)gmail(dot)com>
Subject: Re: effective_wal_level is not decreasing after using REPACK (CONCURRENTLY)
Date: 2026-05-27 18:25:19
Message-ID: CAD21AoDYL_UG5c5MP6GDF5h8L=L+qgrAatyOwhb4a7sN7uW5VA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, May 27, 2026 at 11:20 AM Álvaro Herrera <alvherre(at)kurilemu(dot)de> wrote:
>
> On 2026-May-26, shveta malik wrote:
>
> > On Tue, May 26, 2026 at 3:09 PM Imran Zaheer <imran(dot)zhir(at)gmail(dot)com> wrote:
> > >
> > > Hi,
> > >
> > > Thanks Shveta, I agree with the additional sanity checks and comments.
> >
> > Thanks, v3 LGTM.
>
> Thanks! Pushed with some cosmetic changes.

Thank you for pushing the patch!

>
> One of them was that I wasn't sure of the reason why ApplyLauncherMain()
> isn't requesting logical decoding disable upon dropping the slot, so
> there's now an XXX comment there.

This is because the launcher can acquire only CONFLICT_DETECTION_SLOT
slot and it is a physical slot.

Regards,

--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jim Jones 2026-05-27 18:29:18 Re: Add XMLNamespaces to XMLElement
Previous Message Nathan Bossart 2026-05-27 18:23:04 Re: future of PQfn()