Re: [BUG] wrong refresh when ALTER SUBSCRIPTION ADD/DROP PUBLICATION

From: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Li Japin <japinli(at)hotmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [BUG] wrong refresh when ALTER SUBSCRIPTION ADD/DROP PUBLICATION
Date: 2021-08-06 23:50:19
Message-ID: CAD21AoDX9_kax0p4OioSDt49wNcqjreChL1yjp+94a=S=80R_Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Aug 6, 2021 at 2:50 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Fri, Aug 6, 2021 at 10:09 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> >
> > On Fri, Aug 6, 2021 at 5:09 AM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> > >
> >
> > But, isn't this happening because of your suggestion to compare the
> > current set of relations with relations from publications that doesn't
> > need to be removed? Do we have better ideas to fix or shall we just
> > say that we will refresh based on whatever current set of relations
> > are present in publication to be dropped?
> >
>
> The other options could be that (a) for drop publication, we refresh
> all the publications, (b) for both add/drop publication, we refresh
> all the publications.
>
> Any better ideas?
>
> As this is introduced in PG-14 via the below commit, I am adding
> authors and committer to see if they have any better ideas.
>
> commit 82ed7748b710e3ddce3f7ebc74af80fe4869492f
> Author: Peter Eisentraut <peter(at)eisentraut(dot)org>
> Date: Tue Apr 6 10:44:26 2021 +0200
>
> ALTER SUBSCRIPTION ... ADD/DROP PUBLICATION
>
> Author: Japin Li <japinli(at)hotmail(dot)com>
> Author: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
>

I've added this to Open Items.

Regards,

--
Masahiko Sawada
EDB: https://www.enterprisedb.com/

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Soumyadeep Chakraborty 2021-08-06 23:59:55 Re: Changes to recovery_min_apply_delay are ignored while waiting for delay
Previous Message David Zhang 2021-08-06 22:18:43 Re: [bug] Logical Decoding of relation rewrite with toast does not reset toast_hash