Re: Auditing extension for PostgreSQL (Take 2)

From: Sawada Masahiko <sawada(dot)mshk(at)gmail(dot)com>
To: David Steele <david(at)pgmasters(dot)net>
Cc: Tatsuo Ishii <ishii(at)postgresql(dot)org>, Simon Riggs <simon(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Abhijit Menon-Sen <ams(at)2ndquadrant(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Subject: Re: Auditing extension for PostgreSQL (Take 2)
Date: 2015-04-15 01:52:25
Message-ID: CAD21AoDUG8G90SUo70JL=AKDA4dXGNb_wAc4-MvxtwvuMRO0kA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Apr 15, 2015 at 8:57 AM, David Steele <david(at)pgmasters(dot)net> wrote:
> On 4/14/15 7:13 PM, Tatsuo Ishii wrote:
>> This patch does not apply cleanly due to the moving of pgbench (patch
>> to filelist.sgml failed).
>
> Thank you for pointing that out!
>
> Ironic that it was the commit directly after the one I was testing with
> that broke the patch. It appears the end of the last CF is a very bad
> time to be behind HEAD.
>
> Fixed in attached v8 patch.

Thank you for updating the patch!

I applied the patch and complied them successfully without WARNING.

I tested v8 patch with CURSOR case I mentioned before, and got
segmentation fault again.
Here are log messages in my environment,

=# select test();
LOG: server process (PID 29730) was terminated by signal 11:
Segmentation fault
DETAIL: Failed process was running: select test();
LOG: terminating any other active server processes
WARNING: terminating connection because of crash of another server process
DETAIL: The postmaster has commanded this server process to roll back
the current transaction and exit, because another server process
exited abnormally and possibly corrupted shared memory.
HINT: In a moment you should be able to reconnect to the database and
repeat your command.
FATAL: the database system is in recovery mode

I hope that these messages helps you to address this problem.
I will also try to address this.

Regards,

-------
Sawada Masahiko

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2015-04-15 01:53:59 Re: Turning off HOT/Cleanup sometimes
Previous Message Tatsuo Ishii 2015-04-15 00:37:37 Re: Auditing extension for PostgreSQL (Take 2)