| From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
|---|---|
| To: | Michael Meskes <meskes(at)postgresql(dot)org> |
| Cc: | Kuntal Ghosh <kuntalghosh(dot)2007(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, pgsql-bugs <pgsql-bugs(at)postgresql(dot)org> |
| Subject: | Re: Two phase commit in ECPG |
| Date: | 2017-03-17 22:01:31 |
| Message-ID: | CAD21AoDPmy=uSVcY1=FXuG4KE_dBWAF-mYgQp5DsfnLAF88X7g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
On Fri, Mar 17, 2017 at 5:50 PM, Michael Meskes <meskes(at)postgresql(dot)org> wrote:
>> Thank you for pointing out.
>> Yeah, I agree that the twophase regression test should not be
>> performed by default as long as the default value of
>> max_prepared_transactions is 0. Similar to this, the isolation check
>> regression test does same thing. Attached patch removes sql/twophase
>> from schedule file and add new type of regression test.
>
> Would it be possible to include it in "make check"? Any check that
> needs manual interaction will not be executed nearly is often as the
> others and become much less useful imo.
>
Yes. I added two-phase commit test to "make check" test schedule while
adding new two type of test.
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
| Attachment | Content-Type | Size |
|---|---|---|
| ecpg_prepared_txns_test_v2.patch | application/octet-stream | 1.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | privat | 2017-03-17 22:17:51 | BUG #14593: Service doesn't start |
| Previous Message | Tom Lane | 2017-03-17 20:04:45 | Re: BUG #14512: Backslashes in LIKE |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2017-03-17 22:02:40 | Re: [PATCH] Suppress Clang 3.9 warnings |
| Previous Message | Pritam Baral | 2017-03-17 21:41:28 | Re: Index usage for elem-contained-by-const-range clauses |