Re: Spinlock is missing when updating two_phase of ReplicationSlot

From: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Spinlock is missing when updating two_phase of ReplicationSlot
Date: 2023-01-12 05:05:44
Message-ID: CAD21AoDN5GbpVEq1G6XaTnSSm8RJhvpHZw+ntGhoxqywB4cxTA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jan 12, 2023 at 1:42 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Wed, Jan 11, 2023 at 02:36:17PM +0900, Michael Paquier wrote:
> > Looks right to me, the paths updating the data related to the slots
> > are careful about that, even when it comes to fetching a slot from
> > MyReplicationSlot. I have been looking around the slot code to see if
> > there are other inconsistencies, and did not notice anything standing
> > out. Will fix..
>
> And done, thanks!

Thank you!

Regards,

--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Noah Misch 2023-01-12 05:09:32 Re: allowing for control over SET ROLE
Previous Message Amit Kapila 2023-01-12 05:04:33 Re: Perform streaming logical transactions by background workers and parallel apply