Re: Replication slot drop message is sent after pgstats shutdown.

On Tue, Feb 15, 2022 at 12:09 PM Kyotaro Horiguchi
<horikyota(dot)ntt(at)gmail(dot)com> wrote:
>
> At Mon, 14 Feb 2022 17:20:16 -0800, Andres Freund <andres(at)anarazel(dot)de> wrote in
> > Hi,
> >
> > On 2021-12-22 22:34:45 +0900, Masahiko Sawada wrote:
> > > I've attached an updated patch. Please review it.
> >
> > Sorry for dropping the ball on this again :(. I've pushed the fix with some
> > very minor polishing.

Thanks!

>
> > > > The attached detects that bug, but I'm not sure it's worth expending
> > > > test time, or this might be in the server test suit.
> > >
> > > Thanks. It's convenient to test this issue but I'm also not sure it's
> > > worth adding to the test suit.
> >
> > I think it's definitely worth adding a test, but I don't particularly like the
> > specific test implementation. Primarily because I think it's better to test
> > this in a cluster that stays running, so that we can verify that the slot drop
> > worked. It also doesn't seem necessary to create a separate cluster.
>
> FWIW I agree to the proposed test on the direction.

+1

Regards,

--
Masahiko Sawada
EDB: https://www.enterprisedb.com/