| From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, Kuntal Ghosh <kuntalghosh(dot)2007(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Index maintenance function for BRIN doesn't check RecoveryInProgress() |
| Date: | 2018-06-15 08:37:41 |
| Message-ID: | CAD21AoD87mnqhZ9GQaJxE0MLom_zcwkB=bO04ScWSuiD13k7uw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jun 15, 2018 at 2:20 AM, Alvaro Herrera
<alvherre(at)2ndquadrant(dot)com> wrote:
> On 2018-Jun-14, Michael Paquier wrote:
>
>> On Thu, Jun 14, 2018 at 02:06:57AM +0900, Masahiko Sawada wrote:
>> > On Thu, Jun 14, 2018 at 12:04 AM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
>> >> On 13 June 2018 at 15:51, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:
>> >>> I guess you could go either way ... we're just changing one unhelpful
>> >>> error with a better one: there is no change in behavior. I would
>> >>> backpatch this, myself, and avoid the code divergence.
>> >>
>> >> WAL control functions all say the same thing, so we can do that here also.
>> >
>> > +1
>>
>> +1 for a back-patch to v10. The new error message brings clarity in my
>> opinion.
>
> Pushed, backpatched to 9.5. Thanks!
>
Thank you!
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2018-06-15 08:37:49 | Re: Internal error XX000 with enable_partition_pruning=on, pg 11 beta1 on Debian |
| Previous Message | Aleksander Alekseeev | 2018-06-15 08:33:58 | Re: [GSoC] current working status |