Re: Fixes for create subscription page

Hi,

On Wed, Oct 7, 2026 at 3:59 AM Thom Brown <thom(at)linux(dot)com> wrote:
>
> Hi,
>
> I was looking through the new options for create subscription, and
> found issues with some of the text, so I reviewed the whole page.
> Attached are my proposed changes.
>

Thank you for the patch. The patch overall looks good to me. A one
minor comment:

- be <literal>pg_conflict_detection</literal> as it is reserved for the
+ be <literal>pg_conflict_detection</literal> as it is reserved for
conflict detection.

There are other places where we can apply this change. In func-admin.sgml:

The new slot name cannot be <literal>pg_conflict_detection</literal>,
as it is reserved for the conflict detection.

and

<literal>pg_conflict_detection</literal> as it is reserved for
the conflict detection. The copied logical slot starts from the same

In protocol.sgml:

The name cannot be <literal>pg_conflict_detection</literal> as it
is reserved for the conflict detection.

I think we can backpatch it to v19, where most of the touched text was
added. The remaining changes are wording improvements. What do you
think?

Regards,

--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com