| From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> |
| Subject: | Re: Replication slot stats misgivings |
| Date: | 2021-03-22 04:25:16 |
| Message-ID: | CAD21AoD34aN9F7vYXrYfzfuFA93gX=s7_Ge-cDObjXWyUx9JPw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Mar 20, 2021 at 3:52 AM Andres Freund <andres(at)anarazel(dot)de> wrote:
>
> - If max_replication_slots was lowered between a restart,
> pgstat_read_statfile() will happily write beyond the end of
> replSlotStats.
I think we cannot restart the server after lowering
max_replication_slots to a value less than the number of replication
slots actually created on the server. No?
>
> - pgstat_reset_replslot_counter() acquires ReplicationSlotControlLock. I
> think pgstat.c has absolutely no business doing things on that level.
Agreed.
>
> - PgStat_ReplSlotStats etc use slotname[NAMEDATALEN]. Why not just NameData?
That's because we followed other definitions in pgstat.h that use
char[NAMEDATALEN]. I'm okay with using NameData.
>
> - pgstat_report_replslot() already has a lot of stats parameters, it
> seems likely that we'll get more. Seems like we should just use a
> struct of stats updates.
Agreed.
Regards,
--
Masahiko Sawada
EDB: https://www.enterprisedb.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bharath Rupireddy | 2021-03-22 04:46:33 | Can we remove extra memset in BloomInitPage, GinInitPage and SpGistInitPage when we have it in PageInit? |
| Previous Message | tsunakawa.takay@fujitsu.com | 2021-03-22 04:18:41 | RE: Disable WAL logging to speed up data loading |