| From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Add progress reporting to pg_verifybackup |
| Date: | 2023-02-02 08:56:47 |
| Message-ID: | CAD21AoD=+pmo4u3UryhTnWV+Pf8MDkWyVx6t6LMzPQUijXFZFQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Feb 2, 2023 at 3:12 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Thu, Feb 02, 2023 at 02:57:44PM +0900, Masahiko Sawada wrote:
> > It seems that the --progress option doesn't work with command_like()
> > since the progress information is written in stderr but command_like()
> > doesn't want it.
>
> What about command_checks_all()? It should check for stderr, stdout
> as well as the expected error code.
Seems a good idea. Please find an attached patch.
Regards,
--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Add-progress-reporting-to-pg_verifybackup.patch | application/octet-stream | 9.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | shveta malik | 2023-02-02 09:05:37 | Re: [PATCH] Reuse Workers and Replication Slots during Logical Replication |
| Previous Message | Önder Kalacı | 2023-02-02 08:33:36 | Re: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher |