From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
---|---|
To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Comment in snapbuild.c file |
Date: | 2017-08-14 02:39:12 |
Message-ID: | CAD21AoCuDaJKRWOZDOuDm=RXYtiDgDMvyLoXhxxnAJu8bYkUQw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sun, Aug 13, 2017 at 12:28 PM, Alvaro Herrera
<alvherre(at)2ndquadrant(dot)com> wrote:
> Alvaro Herrera wrote:
>> Masahiko Sawada wrote:
>> > Hi all,
>> >
>> > In snapbuild.c file, there is a comment as follows.
>> >
>> > * NB: Because of that xmax can be lower than xmin, because we only
>> > * increase xmax when a catalog modifying transaction commits. While odd
>> > * looking, it's correct and actually more efficient this way since we hit
>> > * fast paths in tqual.c.
>> > */
>>
>> I think the whole para needs to be rethought.
>
> Pushed, thanks.
>
Sorry for the late response. I agreed with your proposal. Thank you
for committing!
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2017-08-14 03:20:41 | Simplify ACL handling for large objects and removal of superuser() checks |
Previous Message | Craig Ringer | 2017-08-14 02:31:03 | Re: Thoughts on unit testing? |