| From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
|---|---|
| To: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: COPY: validate option presence rather than option values |
| Date: | 2026-06-26 21:09:26 |
| Message-ID: | CAD21AoCsbjvgk5tOarepYF28dW7P6NG8SLVDQ72A7AJ3yEjriw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, May 5, 2026 at 9:26 PM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
>
> Hi,
>
> While testing COPY TO (FORMAT json), I noticed that the doc says FORCE_ARRAY is only allowed with FORMAT json:
> ```
> <varlistentry id="sql-copy-params-force-array">
> <term><literal>FORCE_ARRAY</literal></term>
> <listitem>
> <para>
> Force output of square brackets as array decorations at the beginning
> and end of output, and commas between the rows. It is allowed only in
> <command>COPY TO</command>, and only when using
> <literal>json</literal> format. The default is
> <literal>false</literal>.
> </para>
> </listitem>
> </varlistentry>
> ```
>
> However, this succeeds:
> ```
> evantest=# copy t1 to stdout (format csv, force_array false);
> 1
> ```
>
> So this is clearly validating the parsed value of force_array, rather than whether the option was specified at all.
Hmm, I'm not sure this is actually a problem in practice. It seems
straightforward to me that the documentation stating 'it is allowed
only when...' can be interpreted as 'it is allowed to be enabled only
when...'. My concern is that the proposed patch could make the command
unnecessarily less flexible. This is especially true in cases where
users programmatically generate a template COPY query and pass
explicit boolean values (true/false) to the options. Also, other
commands like VACUUM handle their boolean options in the exact same
manner:
=# vacuum (parallel 1, full) pg_class;
ERROR: VACUUM FULL cannot be performed in parallel
=# vacuum (parallel 1, full off) pg_class;
VACUUM
Regards,
--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bharath Rupireddy | 2026-06-26 21:19:37 | Re: Handle concurrent drop when doing whole database vacuum |
| Previous Message | Masahiko Sawada | 2026-06-26 20:30:23 | Re: Fix race condition in pg_get_publication_tables with concurrent DROP TABLE |