| From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
|---|---|
| To: | Greg Nancarrow <gregn4422(at)gmail(dot)com> |
| Cc: | "osumi(dot)takamichi(at)fujitsu(dot)com" <osumi(dot)takamichi(at)fujitsu(dot)com>, "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, Alexey Lesovsky <lesovsky(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Skipping logical replication transactions on subscriber side |
| Date: | 2022-01-21 03:13:25 |
| Message-ID: | CAD21AoCqTdL=Tv5asV5eMmJyC5pC1ks5mTh7Zhd+x=oeYTtXzg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jan 19, 2022 at 4:14 PM Greg Nancarrow <gregn4422(at)gmail(dot)com> wrote:
>
> On Tue, Jan 18, 2022 at 5:05 PM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> >
> > I've attached a rebased patch.
>
> A couple of comments for the v8 patch:
Thank you for the comments!
>
> doc/src/sgml/logical-replication.sgml
>
> (1)
> Strictly-speaking it's the transaction, not transaction ID, that
> contains changes, so suggesting minor change:
>
> BEFORE:
> + The transaction ID that contains the change violating the constraint can be
> AFTER:
> + The ID of the transaction that contains the change violating the
> constraint can be
>
>
> doc/src/sgml/ref/alter_subscription.sgml
>
> (2) apply_handle_commit_internal
> It's not entirely apparent what commits the clearing of subskixpid
> here, so I suggest the following addition:
>
> BEFORE:
> + * clear subskipxid of pg_subscription.
> AFTER:
> + * clear subskipxid of pg_subscription, then commit.
>
These comments are merged with Peter's comments and incorporated into
the latest v9 patch[1].
Regards,
--
Masahiko Sawada
EDB: https://www.enterprisedb.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2022-01-21 03:14:05 | Re: Skipping logical replication transactions on subscriber side |
| Previous Message | Masahiko Sawada | 2022-01-21 03:11:05 | Re: Skipping logical replication transactions on subscriber side |