| From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
|---|---|
| To: | kyle(at)kyleconroy(dot)com |
| Cc: | pgsql-bugs <pgsql-bugs(at)postgresql(dot)org> |
| Subject: | Re: BUG #14775: Incorrect documentation for the Commit logical replication message format |
| Date: | 2017-08-10 08:21:29 |
| Message-ID: | CAD21AoCkONxpZbkwV8nHNvb-C9CY_iZo5v3VjRZ7NK2zyekVLg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Wed, Aug 9, 2017 at 2:08 PM, <kyle(at)kyleconroy(dot)com> wrote:
> The following bug has been logged on the website:
>
> Bug reference: 14775
> Logged by: Kyle Conroy
> Email address: kyle(at)kyleconroy(dot)com
> PostgreSQL version: 10beta2
> Operating system: macOS
> Description:
>
> The Commit message format is incorrectly documented. The `flags` field[0] is
> missing. I ran into this while creating a parser for the messages in
> Golang.
>
> [0]
> https://github.com/postgres/postgres/blob/master/src/backend/replication/logical/proto.c#L80
>
Thank you for reporting. Yeah, it's not used actually for now but
should be documented. Attached patch.
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
| Attachment | Content-Type | Size |
|---|---|---|
| fix_inconsistent_message_format_in_docs.patch | text/x-patch | 433 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | glenn.burkhardt | 2017-08-10 17:28:48 | BUG #14778: locale 'en-US' not recognized |
| Previous Message | mithscool74 | 2017-08-10 07:02:25 | BUG #14777: Postgres Installation not Successful. |