| From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: doc: improve the restriction description of using indexes on REPLICA IDENTITY FULL table. |
| Date: | 2023-07-07 08:05:40 |
| Message-ID: | CAD21AoCinE5twgez2U9D-z+vnz4HC-wZBOjCmxgGQJcJ_2MKnw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jul 7, 2023 at 10:55 AM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> Hi, Here are my review comments for patch v2.
>
> ======
> 1. doc/src/sgml/logical-replication.sgml
>
> Candidate indexes must be btree, non-partial, and have at least one
> column reference to the published table column at the leftmost column
> (i.e. cannot consist of only expressions).
>
> ~
>
> There is only one column which can be the leftmost one, so the wording
> "At least one ... at the leftmost" seemed a bit strange to me.
> Personally, I would phrase it something like below:
>
> SUGGESTION #1
> Candidate indexes must be btree, non-partial, and the leftmost index
> column must reference a published table column (i.e. the index cannot
> consist of only expressions).
I prefer the first suggestion. I've attached the updated patch.
Regards,
--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Doc-clarify-the-conditions-of-usable-indexes-for-.patch | application/octet-stream | 4.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Damir Belyalov | 2023-07-07 08:08:48 | Re: Implement missing join selectivity estimation for range types |
| Previous Message | Hayato Kuroda (Fujitsu) | 2023-07-07 08:01:21 | RE: [Patch] Use *other* indexes on the subscriber when REPLICA IDENTITY is FULL |