From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
---|---|
To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
Cc: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [HACKERS] Assertion failure when the non-exclusive pg_stop_backup aborted. |
Date: | 2017-12-15 00:51:38 |
Message-ID: | CAD21AoCicW8XcSLP0kEg=e3BPk1NHN1Y5W_+bxdiAiJPYevz0A@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Dec 15, 2017 at 6:46 AM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> On Fri, Dec 15, 2017 at 3:52 AM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>> On Mon, Dec 11, 2017 at 2:16 PM, Michael Paquier
>> <michael(dot)paquier(at)gmail(dot)com> wrote:
>>> On Mon, Dec 11, 2017 at 2:03 PM, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>>>> On Sat, Dec 9, 2017 at 2:24 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>>>>> On Fri, Dec 8, 2017 at 4:13 AM, Michael Paquier
>>>>> <michael(dot)paquier(at)gmail(dot)com> wrote:
>>>>>> I would just write "To
>>>>>> avoid calling CHECK_FOR_INTERRUPTS which can happen when releasing a
>>>>>> LWLock" and be done with it. There is no point to list a full function
>>>>>> dependency list, which could change in the future with static routines
>>>>>> of lwlock.c.
>>>>
>>>> Agreed. Updated the comment.
>>>
>>> Robert actually liked adding the complete routine list. Let's see what
>>> Fujii-san thinks at the end, there is still some time until the next
>>> round of minor releases.
>>
>> What I think is the patch I attached. Thought?
>
> That's OK for me. Thanks.
+1 from me.
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2017-12-15 01:00:29 | Re: [HACKERS] [COMMITTERS] pgsql: Fix freezing of a dead HOT-updated tuple |
Previous Message | Craig Ringer | 2017-12-15 00:49:10 | Re: [HACKERS] Walsender timeouts and large transactions |