| From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
|---|---|
| To: | myungkyu(dot)lim(at)samsung(dot)com |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, woosung(dot)sohn(at)samsung(dot)com, don(dot)hong(at)samsung(dot)com |
| Subject: | Re: FW: [Todo item] Add entry creation timestamp column to pg_stat_replication |
| Date: | 2018-11-15 07:04:44 |
| Message-ID: | CAD21AoCg1UHpYEwp-poDxtpG0rfQpox-m6++tEEJ+0-=pXLhog@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Aug 2, 2018 at 6:34 PM MyungKyu LIM <myungkyu(dot)lim(at)samsung(dot)com> wrote:
>
> I changed field name from 'reply_time' to 'last_msg_send_time'.
> Because 'last_msg_send_time' is used in pg_stat_wal_receiver/pg_stat_subsctiption view.
> I think that field has the same meaning.
I got confused by the field name. If we have 'last_msg_send_time'
field in pg_stat_replciation which has information of wal senders
users would think it as a time when the wal sender sent a message last
time. However values of the fields actually shows a time when the wal
receiver sent a reply message last time. So perhaps
'last_reply_send_time' would be more clear.
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | myungkyu.lim | 2018-11-15 08:02:31 | RE: [Todo item] Add entry creation timestamp column to pg_stat_replication |
| Previous Message | Michael Paquier | 2018-11-15 07:02:15 | Re: [HACKERS] generated columns |