Re: REPACK (CONCURRENTLY) fails when table owner lacks CONNECT

From: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
To: Matheus Alcantara <matheusssilv97(at)gmail(dot)com>
Cc: Nathan Bossart <nathandbossart(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org, alvherre(at)kurilemu(dot)de
Subject: Re: REPACK (CONCURRENTLY) fails when table owner lacks CONNECT
Date: 2026-09-04 18:40:56
Message-ID: CAD21AoCWeSqMCGNwiDeP+qhJ5m4AT564azVEYB=mdzGx6BpKSw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On Thu, Aug 27, 2026 at 12:52 PM Matheus Alcantara
<matheusssilv97(at)gmail(dot)com> wrote:
>
> On 27/08/26 16:19, Nathan Bossart wrote:
> > The patch looks reasonable to me.
> >
> > On Thu, Aug 27, 2026 at 03:55:11PM -0300, Matheus Alcantara wrote:
> >> Added this new test case on attached.
> >
> > I'm not sure the new tests are necessary. It seems unlikely that we'll
> > accidentally remove the flags down the road.
> >
>
> Yeah, I also think that is unlikely that we'll remove, I just put the
> test to be more conservative. I think that is good to have such tests
> to ensure that these bugs are not re-introduced but given that this
> seems a minor/oversight I'm not totally against not adding them.
> Attached is v3 without the tests.

+1 not skipping the test.

The patch looks good to me. I've slightly rephrased the comment and
commit message. I'm going to push it barring any objections.

Regards,

--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com

Attachment Content-Type Size
v4-0001-Fix-REPACK-CONCURRENTLY-when-the-table-owner-lack.patch text/x-patch 2.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Paul A Jungwirth 2026-09-04 18:52:20 FOR PORTION OF leftovers should fire triggers on the child table
Previous Message Andrey Borodin 2026-09-04 18:16:23 Re: Bug: Whole-row var in indexes corrupts indexes after DDL