| From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Greg Nancarrow <gregn4422(at)gmail(dot)com>, "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>, "osumi(dot)takamichi(at)fujitsu(dot)com" <osumi(dot)takamichi(at)fujitsu(dot)com>, Alexey Lesovsky <lesovsky(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Skipping logical replication transactions on subscriber side |
| Date: | 2021-11-29 01:42:22 |
| Message-ID: | CAD21AoCNTko0Qf-F1qVzH8Q9FZk9h_dERNs9BztehrR0SJLr3A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Nov 27, 2021 at 7:56 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Fri, Nov 26, 2021 at 6:00 AM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> >
> > Indeed. Attached an updated patch. Thanks!
> >
>
Thank you for updating the patch!
> I have made a number of changes in the attached patch which includes
> (a) the patch was trying to register multiple array entries for the
> same subscription which doesn't seem to be required, see changes in
> pgstat_vacuum_stat, (b) multiple changes in the test like reduced the
> wal_retrieve_retry_interval to 2s which has reduced the test time to
> half, remove the check related to resetting of stats as there is no
> guarantee that the message will be received by the collector and we
> were not sending it again, changed the test case file name to
> 026_stats as we can add more subscription-related stats in this test
> file itself
Since we have pg_stat_subscription view, how about 026_worker_stats.pl?
The rests look good to me.
Regards,
--
Masahiko Sawada
EDB: https://www.enterprisedb.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Smith | 2021-11-29 02:08:21 | Re: row filtering for logical replication |
| Previous Message | qianglj.fnst@fujitsu.com | 2021-11-29 01:01:55 | Fix typos |