| From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Jan Wieck <jan(at)wi3ck(dot)info>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Initial COPY of Logical Replication is too slow |
| Date: | 2026-03-26 23:51:14 |
| Message-ID: | CAD21AoCLodVegaB=HDfxFMe8s9TMUxj+okznt6yjizN+5TVOfA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Mar 26, 2026 at 3:44 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Wed, Mar 25, 2026 at 10:37 AM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> >
> > I figured out that the join with pg_publication works as a filter;
> > non-existence publication names are not passed to the function. If we
> > pass the list of publication names to the new function signature,
> > while we can simplify the patch and avoid a join, we would change the
> > existing function behavior so that it ignores non-existence
> > publications.
> >
> > I've attached the updated patch. The 0001 patch just incorporated the
> > review comments so far, and the 0002 patch is a draft change for the
> > above idea. Since pg_get_publication_tables(VARIADIC text) is not a
> > documented function, I think we can accept small behavior changes. So
> > I'm going to go with this direction.
> >
>
> What behaviour change are you referring to? In general, the direction
> appears right to me.
When passing a non-existent publication name, the current behavior
raises an error while the new behavior does nothing (i.e., the
difference is calling GetPublicationByName() with missing_ok = true or
false).
Regards,
--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David G. Johnston | 2026-03-26 23:54:12 | Re: [PATCH v1] Replace sprintf() with snprintf() in libpq for safety Anexo: o arquivo |
| Previous Message | Álvaro Herrera | 2026-03-26 23:33:27 | Re: [PATCH v1] Replace sprintf() with snprintf() in libpq for safety Anexo: o arquivo |