Re: Add an option to skip loading missing publication to avoid logical replication failure

From: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: Dilip Kumar <dilipbalaut(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Add an option to skip loading missing publication to avoid logical replication failure
Date: 2025-03-12 21:51:04
Message-ID: CAD21AoCLJyS0+K9--AaQhruSqR_bF2mdm-EUEMnDvxBW14wQjw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Mar 12, 2025 at 3:34 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Tue, Mar 11, 2025 at 9:48 AM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
> >
> > On Mon, Mar 10, 2025 at 10:54 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> > >
> >
> > > >> BTW, I am planning to commit this only on HEAD as this is a behavior
> > > >> change. Please let me know if you guys think otherwise.
> > > >
> > > >
> > > > Somehow this looks like a bug fix which should be backported no? Am I missing something?
> > > >
> > >
> > > We can consider this a bug-fix and backpatch it, but I am afraid that
> > > because this is a behavior change, some users may not like it. Also, I
> > > don't remember seeing public reports for this behavior; that is
> > > probably because it is hard to hit. FYI, we found this via BF
> > > failures. So, I thought it would be better to get this field tested
> > > via HEAD only at this point in time.
> >
> > At the moment, I don't have a strong opinion on this. Since no one has
> > encountered or reported this issue, it might be the case that it's not
> > affecting anyone, and we could simply backpatch without causing any
> > dissatisfaction. However, I'm fine with whatever others decide.
> >
>
> Sawada-San, others, do you have an opinion on whether to backpatch this change?

I'm also afraid of backpatching it so I guess it would be better to
push it to only HEAD. I think if users have encountered and we see
reported the issue we can consider backpatching again. If regression
tests on backbranches continue to fail intermittently, probably we can
consider adding waits as the patch Osumi-san proposed[1]?

Regards,

[1] https://www.postgresql.org/message-id/TYCPR01MB83737A68CD5D554EA82BD7B9EDD39%40TYCPR01MB8373.jpnprd01.prod.outlook.com

--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Sadeq Dousti 2025-03-12 22:00:34 Re: Add connection active, idle time to pg_stat_activity
Previous Message Peter Geoghegan 2025-03-12 20:50:44 Re: Adding skip scan (including MDAM style range skip scan) to nbtree