Re: BUG #14758: Segfault with logical replication on a function index

From: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Scott Milliken <scott(at)deltaex(dot)com>, pgsql-bugs <pgsql-bugs(at)postgresql(dot)org>
Subject: Re: BUG #14758: Segfault with logical replication on a function index
Date: 2017-08-02 01:23:24
Message-ID: CAD21AoCJBTZDZTG28MJdRv8c7iwr721paf_TCe9WydRVWnDhKw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On Wed, Aug 2, 2017 at 7:52 AM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> On 2017-08-01 16:28:31 -0400, Peter Eisentraut wrote:
>> On 7/28/17 06:07, Masahiko Sawada wrote:
>> > I could reproduced this issue and it seems to me that the cause of
>> > this is that the table sync worker didn't get a snapshot before
>> > starting table copy. Attached patch fixes this problem.
>>
>> Should it be GetTransactionSnapshot() rather than GetLatestSnapshot()?
>
> Don't think it makes a meaningful difference here, but I agree it's more
> consistent.

+1.

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message twodragon72 2017-08-02 03:23:53 BUG #14764: #if HASH_DEBUG source in dynahash.c is fault.
Previous Message Andres Freund 2017-08-01 22:52:32 Re: BUG #14758: Segfault with logical replication on a function index

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2017-08-02 01:27:43 Re: A bug in mapping attributes in ATExecAttachPartition()
Previous Message Amit Langote 2017-08-02 01:23:06 Re: A bug in mapping attributes in ATExecAttachPartition()