Re: [HACKERS] Assertion failure when the non-exclusive pg_stop_backup aborted.

From: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] Assertion failure when the non-exclusive pg_stop_backup aborted.
Date: 2017-12-08 08:38:08
Message-ID: CAD21AoCFovV==uDAOAsnDCu8pUjS2PtE_49XZYa4ayQOwJybEg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On Fri, Dec 1, 2017 at 11:51 AM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> On Wed, Nov 29, 2017 at 7:36 AM, Michael Paquier
> <michael(dot)paquier(at)gmail(dot)com> wrote:
>> On Wed, Nov 29, 2017 at 6:44 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>>> On Tue, Nov 21, 2017 at 4:32 AM, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>>>> Thank you for comments. Attached updated patch.
>>>
>>> I see that Michael has marked this Ready for Committer, but also that
>>> he didn't update the thread, so perhaps some interested committer
>>> (Fujii Masao?) might have missed the fact that Michael thinks it's
>>> ready to go.
>>
>> Sorry for not mentioning that directly on the thread.
>>
>>> Anyone interested in taking a look at this one for commit?
>>
>> I would assume that Fujii-san would be the chosen one here as he has
>> worked already on the thread.
>
> No replies yet. So I am moving this patch to next CF.

After off-discussion with Fujii-san, I've updated the comment of why
we should disallow interrupts before setting/cleanup the session-level
lock. Please review it.

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

Attachment Content-Type Size
fix_do_pg_abort_backup_v10.patch application/octet-stream 3.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2017-12-08 09:12:45 ScalarArrayOpExpr and multi-dimensional arrays
Previous Message Andrey Borodin 2017-12-08 08:21:17 Re: CUBE seems a bit confused about ORDER BY