Re: Skip recovery/standby signal files in pg_basebackup

From: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
To: David Steele <david(at)pgmasters(dot)net>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Skip recovery/standby signal files in pg_basebackup
Date: 2019-09-30 07:05:58
Message-ID: CAD21AoCF6jevrVdwoxuu_qAFL=N-Uk3b4zC53Tav7n2d4Ab9Ww@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Sep 28, 2019 at 3:53 AM David Steele <david(at)pgmasters(dot)net> wrote:
>
> Hackers,
>
> Restoring these files could cause surprising behaviors so it seems best
> to let the restore process create them when needed.

It's not a normal situation where a running postgres has either
recovery.signal or standby.signal but I'm +1 on this change for
safety.

The patch looks good to me.

Regards,

--
Masahiko Sawada

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Paul Guo 2019-09-30 07:07:48 Re: Two pg_rewind patches (auto generate recovery conf and ensure clean shutdown)
Previous Message Amit Kapila 2019-09-30 06:06:57 Re: pgbench - allow to create partitioned tables