Re: Fix typo in code comment

From: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
To: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
Cc: kelan <ke_lan1(at)qq(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Fix typo in code comment
Date: 2026-01-05 18:18:05
Message-ID: CAD21AoCE5S7ZpcieKwisZqcGuUKyR=RBZBpMSocOUy59s6MfzA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Jan 4, 2026 at 1:24 AM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
>
>
>
> > On Dec 31, 2025, at 09:10, kelan <ke_lan1(at)qq(dot)com> wrote:
> >
> > Hi hickers,
> > I fixed a comment error in the `WaitForParallelWorkersToFinish` function. The original comment was "In that case, or latch should have been set as well...", where I think "or" is a typo and it should be "our".
> >
> > --
> > Best regards,
> > Ke Lan
> > Email:ke_lan1(at)qq(dot)com
> >
> > <v1-0001-correct-typos-in-the-code-comments.patch>
>
> Looking at the context, “or” doesn’t make sense here. Both “the” and “our” would work grammatically, and given the intent of the comment, “our” seems the most likely original wording.
>

I agree that it's a typo. I've just pushed the patch. Thank you!

Regards,

--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2026-01-05 18:36:50 Re: Adding NetBSD and OpenBSD to Postgres CI
Previous Message Dagfinn Ilmari Mannsåker 2026-01-05 18:11:42 Re: Add "format" target to make and ninja to run pgindent and pgperltidy