Re: Missing comment for max_logical_replication_workers in postgresql.conf.sample

From: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
To: Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Missing comment for max_logical_replication_workers in postgresql.conf.sample
Date: 2017-07-27 05:38:29
Message-ID: CAD21AoCBORO7--n4-VpbmgkagsJUYqQKGVi9cXnS7VZFtS23JA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jul 27, 2017 at 10:14 AM, Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp> wrote:
> Hi,
>
> I found that postgresql.conf.sample is missing a comment
> to note that changing max_logical_replication_workers requires
> restart of the server.
>
> Other such parameters has the comments, so I think the new
> parameter also needs this. Attached is a simple patch to fix
> this.
>

Good point. Similarly, dynamic_shared_memory_type and event_source are
required restarting to change but are not mentioned in
postgresql.conf.sample. Should we add a comment as well?

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Golub 2017-07-27 06:48:36 Re: AlterUserStmt anmd RoleSpec rules in grammar.y
Previous Message Thomas Munro 2017-07-27 05:20:45 Re: Log LDAP "diagnostic messages"?